Closed helenfeng737 closed 2 years ago
/cc @spiffxp
I'm not sure why we'd want presubmits in testgrid. Presubmits are very noisy and the heatmap in prow gives better insight (e.g. PRs that don't build are clearly distinct by runtime)
cc @spiffxp
I got tripped up on this as well. Why do we want to display these tests on TestGrid? They run at variable frequencies against code that may not actually merge or work. Is that grid useful?
It's about ensuring that testgrid can be a consistent gateway to all jobs executed by prow.k8s.io, instead of sometimes having to go view prow's deck, or spyglass' job-history page.
Presubmits aren't guaranteed to pass reliably, but testgrid can still provide a useful visual signal if one set of tests starts failing consistently across presubmits
We discussed this during today's sig-testing meeting. We didn't come to a consensus, but I do want to note what I heard:
For adding all presubmits to TestGrid:
Against requiring presubmits in TestGrid:
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale
/remove-lifecycle stale
Against requiring presubmits in TestGrid:
- Tests may run very frequently, putting strain on TG's frontend
Presubmits should default to shorter retention to avoid this strain
-Tuning staleness and pass/fail thresholds for alerting is too difficult to get good signal out of
Maybe true, but I still think testgrid's summary view can provide me a better glance of "how are merge-blocking presubmits doing" vs looking at https://prow.k8s.io/?repo=kubernetes%2Fkubernetes&type=presubmit at the moment:
I think between configurator getting a little smarter about what kind of information is available from prow config and prow jobs, and possibly supporting multiple defaults, there's room for improvement.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten
I'm not sure we should enforce presubmits in testgrid, I think it would be reasonable to just exclude presubmits from this check and require it for periodic / postsubmit
Periodic / postsubmit we don't want to run if nobody is watching. But presubmits report to PRs.
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen
.
Mark the issue as fresh with /remove-lifecycle rotten
.
Send feedback to sig-contributor-experience at kubernetes/community. /close
@k8s-triage-robot: Closing this issue.
/reopen /remove-lifecycle rotten If we shouldn't enforce this, we should drop the test. Or, finish implementing so there are no more special cases. This middle ground is complexity that doesn't need to be present.
/sig testing
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/reopen
/remove-lifecycle rotten
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closing this issue.
Below are all repos that don't have their presubmits in testgrid. This issue is to track moving this down to just kubernetes-security/
This used to be tracked in the code. Make it an independent issue for easier tracking.
https://github.com/kubernetes/test-infra/blob/master/config/tests/testgrids/config_test.go