kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.83k stars 2.65k forks source link

Migrate merge-blocking jobs to dedicated cluster: pull-kubernetes-e2e-gce-network-proxy-http-connect #18854

Closed spiffxp closed 4 years ago

spiffxp commented 4 years ago

What should be cleaned up or changed:

This is part of #18550

To properly monitor the outcome of this, you should be a member of k8s-infra-prow-viewers@kubernetes.io. PR yourself into https://github.com/kubernetes/k8s.io/blob/master/groups/groups.yaml#L603-L628 if you're not a member.

Migrate pull-kubernetes-e2e-gce-network-proxy-http-connect to k8s-infra-prow-build by adding a cluster: k8s-infra-prow-build field to the job:

NOTE: migrating this job is not as straightforward as some of the other #18550 issues, because:

Once the PR has merged, note the date/time it merged. This will allow you to compare before/after behavior.

Things to watch for the job

Things to watch for the build cluster

Keep this open for at least 24h of weekday PR traffic. If everything continues to look good, then this can be closed.

/wg k8s-infra /sig testing /area jobs /help

RobertKielty commented 4 years ago

/assign /remove-help

RobertKielty commented 4 years ago

@spiffxp I submitted a PR for this a few days ago but failed to add "fixes" in order to link it back to this issue.

When you get a chance can you take a look and approve the change? Many thanks.

spiffxp commented 4 years ago

https://github.com/kubernetes/test-infra/pull/19153 has a merge conflict

I'll trigger a few more runs and keep an eye on https://prow.k8s.io/pr-history/?org=kubernetes&repo=kubernetes&pr=94127

This job runs so infrequently that as long as its behavior looks close to the gce or ubuntu e2e jobs I'll be happy with it once the real job is replaced with the changes in the canary (minus the testgrid dashboard change)