Closed dprotaso closed 3 months ago
/area prow/peribolos /area prow
IMHO this is less of a bug and more of a feature request? I don't think it's that this feature is broken, I think it doesn't exist? I bet the owners would be happy to see this implemented. /sig testing /sig contributor-experience cc @mrbobbytables @cblecker
Feel free to reclassify it as needed
On Tue, Feb 16, 2021 at 17:56 Benjamin Elder notifications@github.com wrote:
IMHO this is less of a bug and more of a feature request? I don't think it's that this feature is broken, I think it doesn't exist? I bet the owners would be happy to see this implemented. /sig testing /sig contributor-experience cc @mrbobbytables https://github.com/mrbobbytables @cblecker https://github.com/cblecker
— You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/kubernetes/test-infra/issues/20872#issuecomment-780171130, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAERAQYDL7VESJAOMIYLVDS7LZZ3ANCNFSM4XXFFRAQ .
cc @cblecker @mrbobbytables
Marking this issue as help wanted. /help
If you are a new contributor who would like to pick this up, here's how you can go about this:
Background about peribolos:
Feature Request:
Background about the code:
orgInvitations
but doesn't check for expired/failed invitations.Changes to make:
I haven't thought about this too much, so there is perhaps a better way to work with the GitHub API for this feature. I'd recommend taking a deeper look at how the GitHub API works with invitations to understand this - https://docs.github.com/en/rest/reference/orgs#members
This approach would probably lead to an extra API call. This should not be problematic because it'll only be triggered on a peribolos run, which isn't too often.
I'd also recommend trying out with a dummy org to verify that this feature works.
Check if the "list failed invitations" GitHub API call correctly looks for expired invitations.
You might need to add a new method in the prow github client for listing failed invitations ListFailedOrgInvitations
similar to ListOrgInvitations
: https://github.com/kubernetes/test-infra/blob/5d56b77ab5fefb5b614a4966b4f92b5fe18b0dd7/prow/github/client.go#L1335
Use ListFailedOrgInvitations
in the inviteClient
: https://github.com/kubernetes/test-infra/blob/e9bafa1cc6be4c8fae4046cef5aeccaa28b3a648/prow/cmd/peribolos/main.go#L794-L796
Add tests for peribolos and the github client.
If you have questions or need help, please ask in the #prow channel on slack.
@nikhita: This request has been marked as needing help from a contributor.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help
command.
I would like to work on this 🤗😄
/assign
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale
/lifecycle frozen
@daemon1024 do you still plan on working on this issue?
Sorry for providing no updates. I tried to work on this but the 7 days wait for testing hampered the process.
I made some attempts at https://github.com/daemon1024/test-infra/commit/b57e191aed9b381617e0d82474dc8f9ead744adb. If this helps.
I will unassign myself from this since I don't have bandwidth to work on this right now. Apologies again.
I tried to work on this but the 7 days wait for testing hampered the process.
What's the 7 day wait for testing?
Need to wait for an invite to expire. The time period for an invite to expire is 7 days.
I would like to pick this up /assign
From my observations, after 7 days, the failed invitations are not returned by /orgs/{org}/invitations
endpoint and are successfully returned by /orgs/{org}/failed_invitations
@bhumijgupta are you still working on this?
This is now at https://github.com/kubernetes-sigs/prow/tree/main/cmd/peribolos and we should track issues in that repo.
This issue has had no activity for years now, so I'm going to close it. If there is further interest please re-file in kubernetes-sigs/prow and link back to this issue for historical context.
For now we have options to work around this, and we have very limited bandwidth to work on features.
What happened: A user added themselves to a peribolos config and an invite was sent. The invite expired and peribolos didn't resend the invite.
What you expected to happen: Peribolos checks the invite status and if expired resends the org invitation.
How to reproduce it (as minimally and precisely as possible):
Please provide links to example occurrences, if any:
Anything else we need to know?: