search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.82k stars 2.64k forks source link

Cherrypicker plugin: Find GitHub account and deploy #23469

Closed alvaroaleman closed 3 years ago

alvaroaleman commented 3 years ago

We added manifests and config for the cherrypicker plugin in https://github.com/kubernetes/test-infra/pull/16329

However this is not quite enough because:

/cc @spiffxp @dims @vincepri

alvaroaleman commented 3 years ago

/sig testing

cjwagner commented 3 years ago

cc @mpherman2 /assign @droslean The invalid config is spamming the Prow logs: "Post "http://cherrypicker": dial tcp: lookup cherrypicker on 10.111.240.10:53: no such host"

spiffxp commented 3 years ago

I'm gonna make an external cherry picker bot user for this

spiffxp commented 3 years ago

/assign

alvaroaleman commented 3 years ago

We added the deployment in #23471 and from the manifests and config it looks to me like it should work, however when trying it out it does not: https://github.com/kubernetes-sigs/controller-runtime/pull/1640#issuecomment-915432338

Could someone with access to the prow cluster check if its indeed deployed and running?

cjwagner commented 3 years ago

Could someone with access to the prow cluster check if its indeed deployed and running?

The deployment exists, but there are no associated pods. The deployment status includes this:

  - lastTransitionTime: "2021-09-08T15:05:51Z"
    lastUpdateTime: "2021-09-08T15:05:51Z"
    message: 'pods "cherrypicker-5d78d679f8-" is forbidden: error looking up service
      account default/cherrypicker: serviceaccount "cherrypicker" not found'
    reason: FailedCreate
    status: "True"
    type: ReplicaFailure

It doesn't look like we actually need a service account so I made a PR to remove the reference: https://github.com/kubernetes/test-infra/pull/23517

alvaroaleman commented 3 years ago

It doesn't look like we actually need a service account so I made a PR to remove the reference: #23517

It still doesn't appear to be working unfortunately: https://github.com/kubernetes-sigs/controller-runtime/pull/1640#issuecomment-916072276

spiffxp commented 3 years ago

Still working on getting an account for you, it was flagged by abuse prevention on creation, still working on getting that addressed

spiffxp commented 3 years ago

OK after the following PR's:

I believe https://github.com/k8s-infra-cherrypick-robot will open PRs. It's not yet an org member but I think this should be capable of working without that?

spiffxp commented 3 years ago

Not quite. Found a typo, https://github.com/kubernetes/test-infra/pull/23556 should address

spiffxp commented 3 years ago

/priority important-soon /milestone v1.23

spiffxp commented 3 years ago

Worked: https://github.com/kubernetes-sigs/controller-runtime/pull/1661

I'd like to get the bot added as an org member before calling this done, is there anything else you can think of @alvaroaleman ?

alvaroaleman commented 3 years ago

I'd like to get the bot added as an org member before calling this done, is there anything else you can think of @alvaroaleman ?

Nope, that should be it. Thanks a lot for picking this up!