search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.82k stars 2.64k forks source link

Prow issue: bot not merging PRs in cloud-provider-openstack #31462

Closed zetaab closed 9 months ago

zetaab commented 9 months ago

We have few PRs that do have lgtm and approve labels. https://github.com/kubernetes/cloud-provider-openstack/pulls?q=is%3Apr+is%3Aopen+label%3Aapproved+label%3Algtm but the bot is not merging these.

https://github.com/kubernetes/cloud-provider-openstack/pull/2509 Pending — Not mergeable. Retesting 3 jobs. https://github.com/kubernetes/cloud-provider-openstack/pull/2489 in merge pool but not progressing? https://github.com/kubernetes/cloud-provider-openstack/pull/2478 labels added 2 days ago, still not merging?

zetaab commented 9 months ago

/sig testing

BenTheElder commented 9 months ago

https://prow.k8s.io/tide

=>

https://prow.k8s.io/?repo=kubernetes%2Fcloud-provider-openstack

they're failing in CI

BenTheElder commented 9 months ago

Looks like your CI scripts require an individual PR_NUMBER which is not going to work for batch testing.

Breaking batch testing will mess up the merge robot.

zetaab commented 9 months ago

@BenTheElder do you have idea why we have not seen that bug before? That code is last time modified 2 years ago. Perhaps we did not have multiple PRs merging at the same before?

BenTheElder commented 9 months ago

Possibly, I also think prow might have a regression in falling back to serial testing, which we've seen before (it should be testing one PR alongside the batch and merging that one if the batch fails)

zetaab commented 9 months ago

thanks @BenTheElder

dulek commented 9 months ago

@BenTheElder: Seems like https://github.com/kubernetes/cloud-provider-openstack/blob/96f2edbfbac24e25660d809669f55c139f12edce/tests/ci-occm-e2e.sh#L34 was there all the time. Can you help me understand how the CI scripts should check out the PRs if no PULL_NUMBER is given?