Closed bitoku closed 1 month ago
Welcome @bitoku!
It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/test-infra has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bitoku Once this PR has been reviewed and has the lgtm label, please assign kannon92 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @bitoku. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
ok I know why the test failed. I will fix it.
The cause of this test failure wasn't because of this discrepancy. I'm gonna close this PR and create a new one.
This PR fixes the test issue observed in https://github.com/kubernetes/kubernetes/pull/123518 .
According to https://github.com/containers/storage/blob/main/docs/containers-storage.conf.5.md ,
Since SELinux is enabled on the test environment,
graphroot
should have the same label as the default locations, but thisgraphroot
doesn't.The main aim is not to change the
graphroot
but to splitimagestore
, so I madegraphroot
andrunroot
default as well.