kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.81k stars 2.62k forks source link

Fix `graphroot` path to be the same as default. #32745

Closed bitoku closed 1 month ago

bitoku commented 1 month ago

This PR fixes the test issue observed in https://github.com/kubernetes/kubernetes/pull/123518 .

According to https://github.com/containers/storage/blob/main/docs/containers-storage.conf.5.md ,

When changing the graphroot location on an SELINUX system, ensure the labeling matches the default locations labels with the following commands:

Since SELinux is enabled on the test environment, graphroot should have the same label as the default locations, but this graphroot doesn't.

The main aim is not to change the graphroot but to split imagestore, so I made graphroot and runroot default as well.

k8s-ci-robot commented 1 month ago

Welcome @bitoku!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bitoku Once this PR has been reviewed and has the lgtm label, please assign kannon92 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[jobs/e2e_node/crio/OWNERS](https://github.com/kubernetes/test-infra/blob/master/jobs/e2e_node/crio/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 month ago

Hi @bitoku. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
haircommander commented 1 month ago

/ok-to-test

bitoku commented 1 month ago

ok I know why the test failed. I will fix it.

bitoku commented 1 month ago

The cause of this test failure wasn't because of this discrepancy. I'm gonna close this PR and create a new one.