search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.81k stars 2.62k forks source link

sig-scheduling: add pull-kubernetes-scheduler-perf #32748

Closed pohly closed 1 month ago

pohly commented 1 month ago

We want to test scheduler_perf changes in Kubernetes PRs, so we have to define a job for it here. In contrast to the corresponding job(s) in kubernetes/test-infra, this one here is owned only by SIG Scheduling as the owner of the code.

I decided against removing the pull-scheduler-perf from kubernetes/test-infra because it might be useful there - can be decided later.

/assign @kerthcet

kerthcet commented 1 month ago

Seems I'm not the approver for this.

pohly commented 1 month ago

/assign @Huang-Wei @alculquicondor

For approval. Optional job, may or not work - we'll have to try it.

pohly commented 1 month ago

Both seem to be on vacation.

/assign @aojea

Can you perhaps help out and approve. I'm sure they won't mind.

kerthcet commented 1 month ago

ping @ahg-g

aojea commented 1 month ago

/approve

relying approval, as optional true and always_run false , with SIG approval

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, kerthcet, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/jobs/kubernetes/sig-scheduling/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-scheduling/OWNERS)~~ [aojea] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 month ago

@pohly: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

In response to [this](https://github.com/kubernetes/test-infra/pull/32748): >We want to test scheduler_perf changes in Kubernetes PRs, so we have to define a job for it here. In contrast to the corresponding job(s) in kubernetes/test-infra, this one here is owned only by SIG Scheduling as the owner of the code. > >I decided against removing the pull-scheduler-perf from kubernetes/test-infra because it might be useful there - can be decided later. > >/assign @kerthcet Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
alculquicondor commented 1 month ago

It looks like the job worked, but there are other problems https://github.com/kubernetes/kubernetes/pull/125527#issuecomment-2175607235