search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.83k stars 2.64k forks source link

sig-scheduling: fix pull-kubernetes-scheduler-perf #32756

Closed pohly closed 3 months ago

pohly commented 3 months ago

PATH must include etcd. Setting KUBE_TEST_VMODULE is not needed and led to weird quoting. The -run=^4 for "run no unit tests" also was problematic (undefined variable ' '). -run=xxxxx is simpler.

 + /bin/sh -c './hack/install-etcd.sh && make test-integration WHAT=./test/integration/scheduler_perf ETCD_LOGLEVEL=warn KUBE_TEST_VMODULE="'\'''\''" KUBE_TEST_ARGS="-run=^$ -benchtime=1ns -bench=BenchmarkPerfScheduling"'
 Downloading https://github.com/etcd-io/etcd/releases/download/v3.5.14/etcd-v3.5.14-linux-amd64.tar.gz succeed
 make: warning: undefined variable ' '
+++ [0614 09:44:46] Checking etcd is on PATH
+++ [0614 09:44:46] Cannot find etcd, cannot run integration tests.
+++ [0614 09:44:46] Please see https://git.k8s.io/community/contributors/devel/sig-testing/integration-tests.md#install-etcd-dependency for instructions.

/assign @aojea

aojea commented 3 months ago

/lgtm /approve

Funny, I'm surprised there is not a simpler way in golang but does not seem a big deal

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/jobs/kubernetes/sig-scheduling/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-scheduling/OWNERS)~~ [aojea] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 3 months ago

@pohly: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

In response to [this](https://github.com/kubernetes/test-infra/pull/32756): >PATH must include etcd. Setting KUBE_TEST_VMODULE is not needed and led to weird quoting. The -run=^4 for "run no unit tests" also was problematic (undefined variable ' '). -run=xxxxx is simpler. > > + /bin/sh -c './hack/install-etcd.sh && make test-integration WHAT=./test/integration/scheduler_perf ETCD_LOGLEVEL=warn KUBE_TEST_VMODULE="'\'''\''" KUBE_TEST_ARGS="-run=^$ -benchtime=1ns -bench=BenchmarkPerfScheduling"' > Downloading https://github.com/etcd-io/etcd/releases/download/v3.5.14/etcd-v3.5.14-linux-amd64.tar.gz succeed > make: warning: undefined variable ' ' > +++ [0614 09:44:46] Checking etcd is on PATH > +++ [0614 09:44:46] Cannot find etcd, cannot run integration tests. > +++ [0614 09:44:46] Please see https://git.k8s.io/community/contributors/devel/sig-testing/integration-tests.md#install-etcd-dependency for instructions. > >/assign @aojea Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.