search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.82k stars 2.64k forks source link

sig-node: use double-quotes for e2e_node test args, II #32776

Closed pohly closed 3 months ago

pohly commented 3 months ago

e2e_node tests are sensitive to how args are quoted because eventually the arguments get embedded in a bash -c invocation via ssh. Double quotes inside the argument work, single quotes don't.

/assign @dims

dims commented 3 months ago

/approve /lgtm

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, pohly, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/jobs/kubernetes/sig-node/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-node/OWNERS)~~ [SergeyKanzhelev,dims] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 3 months ago

@pohly: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

In response to [this](https://github.com/kubernetes/test-infra/pull/32776): >e2e_node tests are sensitive to how args are quoted because eventually the arguments get embedded in a `bash -c` invocation via ssh. Double quotes inside the argument work, single quotes don't. > >/assign @dims Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.