search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.81k stars 2.61k forks source link

skip NodeSwap test in Serial test #32783

Closed bitoku closed 2 weeks ago

bitoku commented 3 weeks ago

NodeSwap test fails in pr-node-kubelet-serial-crio-cgroupv2 because it doesn't set up swap memory. This PR skips the NodeSwap test in the test.

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/125417/pull-kubernetes-node-kubelet-serial-crio-cgroupv2/1800694627741732864

k8s-ci-robot commented 3 weeks ago

Hi @bitoku. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bitoku Once this PR has been reviewed and has the lgtm label, please assign yujuhong for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[config/jobs/kubernetes/sig-node/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-node/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bitoku commented 3 weeks ago

cc: @iholder101

iholder101 commented 3 weeks ago

Thank you for this PR @bitoku!

However, I think that this PR should be closed in favor of https://github.com/kubernetes/kubernetes/pull/125402. It skips this case in-test, so will cover these failures across all lanes and not specifically the one you target in this PR. WDYT?

bitoku commented 2 weeks ago

I didn't know that you already opened it. It should fix the test failure. Thank you for letting me know!