search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.81k stars 2.61k forks source link

chore: pin go versions in k/sig-k8s-infra #32791

Open Okabe-Junya opened 3 weeks ago

Okabe-Junya commented 3 weeks ago

Change List

ref. https://github.com/kubernetes/registry.k8s.io/pull/283#issuecomment-2179062933

I don’t know where the golang image in config/jobs/kubernetes/sig-k8s-infra/registry.k8s.io/sig-k8s-infra-registry-presubmits.yaml in k/test-infra is referenced to. (Docker Hub?)

It seems to be running with Go 1.21.3, so I want to update/pin this (and this is causing the error).

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Okabe-Junya Once this PR has been reviewed and has the lgtm label, please assign upodroid for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[config/jobs/kubernetes/sig-k8s-infra/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-k8s-infra/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Okabe-Junya commented 3 weeks ago

FYI: I have written the context

See https://kubernetes.slack.com/archives/CCK68P2Q2/p1718816152584299

BenTheElder commented 2 weeks ago

we should just use go toolchain support instead.

BenTheElder commented 2 weeks ago

https://go.dev/doc/toolchain

Okabe-Junya commented 2 weeks ago

/hold

Discuss at https://github.com/kubernetes/k8s.io/pull/6908 and determine how to proceed with this PR based on the conclusion