search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.81k stars 2.61k forks source link

etcd: Add golvuncheck for 3.4, 3.5 #32801

Open ArkaSaha30 opened 2 weeks ago

ArkaSaha30 commented 2 weeks ago

This commit will run pull-etcd-govulncheck for release-3.4, release-3.5 branch in addition to main. Issue link: https://github.com/kubernetes/test-infra/issues/32754

cc @ivanvc

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArkaSaha30 Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[config/jobs/etcd/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/etcd/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ivanvc commented 2 weeks ago

@jmhbnz, do we want to migrate jobs from branches other than main to prow? I haven't opened pull requests that run for 3.4/3.5 mainly because the Makefiles as stated above, are not always 100% compatible, and also because I haven't seen an effort to migrate these two branches.

jmhbnz commented 2 weeks ago

@jmhbnz, do we want to migrate jobs from branches other than main to prow? I haven't opened pull requests that run for 3.4/3.5 mainly because the Makefiles as stated above, are not always 100% compatible, and also because I haven't seen an effort to migrate these two branches.

Good question - We could discuss at community meeting potentially or cc @ahrtr and @serathius for async decision. Personally I would be in favor.

ahrtr commented 2 weeks ago

do we want to migrate jobs from branches other than main to prow?

I do not see a reason not to do it. So yes to me.

ivanvc commented 2 weeks ago

Link to etcd-io/etcd#18173.

Regardless of the previous comment and outcome. I think we're ready to drop the optional: true and tune the requested CPU/memory. I was going to do it in a separate pull request, but I think it's fine if you update the values. The CPU should be at 4, and we can lower the memory to 1Gi, based on one week's usage (Grafana).