search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.81k stars 2.61k forks source link

Wire in GitHub App authentication for the commenter and update job flags #32806

Open tnozicka opened 2 weeks ago

tnozicka commented 2 weeks ago

This PR adds GitHub App authentication for commenter robot and unifies the flags and client building with prow machinery. Unfortunately, this requires changing the flag names (mostly prefixed by github-, so I've updated the jobs as well.

Resolves #32805

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tnozicka Once this PR has been reviewed and has the lgtm label, please assign cjwagner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[config/jobs/kubernetes/sig-k8s-infra/trusted/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-k8s-infra/trusted/OWNERS)** - **[robots/OWNERS](https://github.com/kubernetes/test-infra/blob/master/robots/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tnozicka commented 2 weeks ago

Here is a successful run with an image built from this PR using the GitHub App credentials https://prow.scylla-operator.scylladb.com/view/gs/scylla-operator-prow/logs/ci-scylla-operator-triage-robot-stale-issues/1804094275261042688