search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.81k stars 2.61k forks source link

Don't build or bump gcsweb and pr-creator images. #32816

Open michelle192837 opened 2 weeks ago

michelle192837 commented 2 weeks ago

These images aren't referenced anywhere, though the code is used independently through other images (registry.k8s.io/gcsweb and gcr.io/k8s-staging-infra-tools/k8s-infra). Remove it from the build/push rules and autobump.

Ref: #32432

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/test-infra/blob/master/OWNERS)~~ [michelle192837] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
BenTheElder commented 2 weeks ago

registry.k8s.io/gcsweb and gcr.io/k8s-staging-infra-tools/k8s-infra

Wait, how are those being pushed? Are these actually unrelated?

michelle192837 commented 2 weeks ago

The gcr.io/k8s-prow versions are built/pushed by post-test-infra-push-misc-images. For the other locations:

No idea if registry.k8s.io/gcsweb is being pushed at all, though it looks like it was last uploaded in August 2022. (Maybe just copied over from migration? https://github.com/kubernetes/k8s.io/blob/9f67194fc0b651b5c9486eeecd9ad5762a681f31/k8s.gcr.io/archived/images/DO-NOT-MODIFY-legacy-backfill/images.yaml). I think it just gets deployed using the existing image and isn't auto-pushed: https://github.com/kubernetes/test-infra/blob/36bb8f575836cdae5a774c3a161e5ab9aa398154/config/jobs/kubernetes/sig-k8s-infra/trusted/sig-k8s-infra-apps.yaml#L87.

gcr.io/k8s-staging-infra-tools/k8s-infra is being pushed by post-k8sio-push-image-k8s-infra I think.