search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.81k stars 2.61k forks source link

Add docker preset to verify-all PDCSI presubmit #32831

Closed pwschuurman closed 6 days ago

pwschuurman commented 1 week ago

This change allows https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1762 to run docker in the gcp-compute-persistent-disk-csi-driver verify presubmit. The docker-in-docker script is used to validate that there are no missing dependencies in the output container images.

pwschuurman commented 1 week ago

/assign @Sneha-at

Sneha-at commented 1 week ago

/lgtm /approve

Sneha-at commented 1 week ago

/assign @msau42

pwschuurman commented 6 days ago

/assign @mattcary

mattcary commented 6 days ago

/approve

k8s-ci-robot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, pwschuurman, Sneha-at

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/jobs/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/OWNERS)~~ [mattcary] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 6 days ago

@pwschuurman: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

In response to [this](https://github.com/kubernetes/test-infra/pull/32831): >This change allows https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1762 to run docker in the gcp-compute-persistent-disk-csi-driver `verify` presubmit. The docker-in-docker script is used to validate that there are no missing dependencies in the output container images. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.