search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.81k stars 2.61k forks source link

Revert "Update gcp-pd-csi pull-gcp-compute-persistent-disk-csi-driver-e2e to use prow-build ServiceAccount" #32842

Closed pwschuurman closed 19 hours ago

pwschuurman commented 1 week ago

This reverts commit bf557df6c512dab17c081c8e93199dc2d2dcf246.

pwschuurman commented 1 week ago

Goal was to use the existing prow-build ServiceAccount for gcp-pd-csi presubmits. It seems that using the default SA is a better choice, and we should just update the default SA to include the appropriate cloudkms permissions.

pwschuurman commented 1 week ago

/hold Discussion ongoing on https://kubernetes.slack.com/archives/CCK68P2Q2/p1719354766854019 on the preferred approach

pwschuurman commented 6 days ago

Using the default compute SA is the preferred approach. Moving forward with reverting this change.

pwschuurman commented 6 days ago

/unhold

pwschuurman commented 6 days ago

/assign @mattcary

mattcary commented 20 hours ago

/lgtm /approve

k8s-ci-robot commented 20 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/jobs/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/OWNERS)~~ [mattcary] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 19 hours ago

@pwschuurman: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

In response to [this](https://github.com/kubernetes/test-infra/pull/32842): >This reverts commit bf557df6c512dab17c081c8e93199dc2d2dcf246. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.