search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.81k stars 2.61k forks source link

remove google-soak dashboard #32857

Closed BenTheElder closed 6 days ago

BenTheElder commented 6 days ago

The one job in this is not passing, doesn't appear to be used.

If we discover anyone does want this job, we should add it back under a different dashboard.

This branch also contains https://github.com/kubernetes/test-infra/pull/32856, because it's smaller (only the first commit) and these PRs are going to conflict on changes to config/testgrids/google/google.yaml if done in parallel.

I'm hoping #32856 merges first and then this will just be the second and third commit, but merging as one PR would also be fine with me anyhow ...

dims commented 6 days ago

/approve /lgtm

k8s-ci-robot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/jobs/kubernetes/kops/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/kops/OWNERS)~~ [BenTheElder,dims] - ~~[config/jobs/kubernetes/sig-cloud-provider/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-cloud-provider/OWNERS)~~ [BenTheElder,dims] - ~~[config/testgrids/google/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/testgrids/google/OWNERS)~~ [BenTheElder,dims] - ~~[config/testgrids/kubernetes/sig-cli/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/testgrids/kubernetes/sig-cli/OWNERS)~~ [BenTheElder,dims] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
BenTheElder commented 6 days ago

missed a reference to the failing test / dashboard (https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/32857/pull-test-infra-unit-test/1806155236738338816), fixed in additional commit https://github.com/kubernetes/test-infra/pull/32857/commits/746a4bd8e5554a2857cb1f34a9d4320a0916ca78

aojea commented 6 days ago

/lgtm

k8s-ci-robot commented 6 days ago

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

In response to [this](https://github.com/kubernetes/test-infra/pull/32857): >The one job in this is not passing, doesn't appear to be used. > >If we discover anyone does want this job, we should add it back under a different dashboard. > >This branch also contains https://github.com/kubernetes/test-infra/pull/32856, because it's smaller (only the first commit) and these PRs are going to conflict on changes to `config/testgrids/google/google.yaml` if done in parallel. > >I'm hoping #32856 merges first and then this will just be the second and third commit, but merging as one PR would also be fine with me anyhow ... Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.