search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.82k stars 2.64k forks source link

Switch off NodeSwap for AWS CI jobs that use AL2 based images (Take 2) #32876

Closed dims closed 3 months ago

dims commented 3 months ago

Duh! NodeSwap should be false

Related to: https://github.com/kubernetes/kubernetes/issues/125173

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/jobs/kubernetes/sig-node/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-node/OWNERS)~~ [dims] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dims commented 3 months ago

want to make sure this works over the weekend, so throwing a skip-review label to get this to merge.

ameukam commented 3 months ago

/lgtm

k8s-ci-robot commented 3 months ago

@dims: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

In response to [this](https://github.com/kubernetes/test-infra/pull/32876): >Duh! `NodeSwap` should be `false` Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.