search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.83k stars 2.65k forks source link

move prow sa to azure optional testconfig from the preset #32883

Closed nawazkh closed 3 months ago

nawazkh commented 3 months ago

This PR will move prow sa variable to azure optional testconfig from the preset since the variable substitution in the pod spec does not work

Screenshot 2024-07-01 at 1 34 20 PM
k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, nawazkh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/jobs/kubernetes-sigs/cluster-api-provider-azure/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api-provider-azure/OWNERS)~~ [jackfrancis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 3 months ago

@nawazkh: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

In response to [this](https://github.com/kubernetes/test-infra/pull/32883): >This PR will move prow sa variable to azure optional testconfig from the preset since the variable substitution in the pod spec does not work >Screenshot 2024-07-01 at 1 34 20 PM > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.