search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.83k stars 2.65k forks source link

Move all NFD Prow jobs to Community cluster #32887

Closed ArangoGutierrez closed 3 months ago

ArangoGutierrez commented 3 months ago

As seen at https://groups.google.com/a/kubernetes.io/g/dev/c/p6PAML90ZOU

ArangoGutierrez commented 3 months ago

/cc @BenTheElder @marquiz

ArangoGutierrez commented 3 months ago

Fixes https://github.com/kubernetes-sigs/node-feature-discovery/issues/1747

ArangoGutierrez commented 3 months ago

/test pull-test-infra-verify-lint

BenTheElder commented 3 months ago

failing linters

BenTheElder commented 3 months ago

/approve /hold

ArangoGutierrez commented 3 months ago

/test pull-test-infra-verify-lint

ArangoGutierrez commented 3 months ago

failing linters

the lints that trigger the failure are not on NFD files, how can we pass by this, should I rebase on master or something?

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/jobs/kubernetes-sigs/node-feature-discovery/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/node-feature-discovery/OWNERS)~~ [ArangoGutierrez,BenTheElder] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ArangoGutierrez commented 3 months ago

/test pull-test-infra-unit-test

BenTheElder commented 3 months ago

/hold cancel /retest

BenTheElder commented 3 months ago 
config/jobs/kubernetes-sigs/node-feature-discovery/node-feature-discovery-postsubmits.yaml
  31:24     error    trailing spaces  (trailing-spaces)
  77:26     error    no new line character at the end of file  (new-line-at-end-of-file)
  77:24     error    trailing spaces  (trailing-spaces)

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/32887/pull-test-infra-verify-lint/1808204092611235840

BenTheElder commented 3 months ago

the lints that trigger the failure are not on NFD files, how can we pass by this, should I rebase on master or something?

the other lints are warnings, which are not the failure, NFD is failing (see above, you can click to expand the log lines for more detail)

ArangoGutierrez commented 3 months ago

the lints that trigger the failure are not on NFD files, how can we pass by this, should I rebase on master or something?

the other lints are warnings, which are not the failure, NFD is failing (see above, you can click to expand the log lines for more detail)

Fixed

k8s-ci-robot commented 3 months ago

@ArangoGutierrez: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

In response to [this](https://github.com/kubernetes/test-infra/pull/32887): >As seen at https://groups.google.com/a/kubernetes.io/g/dev/c/p6PAML90ZOU Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.