search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.82k stars 2.63k forks source link

CC multiple people does not work anymore #32905

Closed gregpavl closed 2 months ago

gregpavl commented 2 months ago

What happened:

We update the prow components from v20231227 to v20240515.

example: 

-        image: gcr.io/k8s-prow/prow-controller-manager:v20231227-1f5d684b52
+        image: gcr.io/k8s-prow/prow-controller-manager:v20240515-dd5d0eeaa

Before the update, the command /cc @person_1 @person_2 @person_3 @person_4 was CC the GH usernames correctly (all at once) in the PRs. After the update, the CC functionality seems broken. If you try to CC multiple people, the bot will catch only the first CCed user.

What you expected to happen:

to continue CC multiple people with the same command inline at once.

How to reproduce it (as minimally and precisely as possible):

try to CC people on the same line. /cc @person_1 @person_2 @person_3 @person_4

Right now, you need to do CC people in separate comments.

Eg. Comment 1: /cc @person_1 Comment 2: /cc @person_2 Comment 3: /cc @person_3 Comment 4: /cc @person_4

Please provide links to example occurrences, if any:

n/a

Anything else we need to know?:

k8s-ci-robot commented 2 months ago

There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:

Please see the group list for a listing of the SIGs, working groups, and committees available.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
droslean commented 2 months ago

/close

k8s-ci-robot commented 2 months ago

@droslean: Closing this issue.

In response to [this](https://github.com/kubernetes/test-infra/issues/32905#issuecomment-2208677266): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.