search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.82k stars 2.63k forks source link

sig-testing: keep the canary job identical to the normal job #32907

Closed carlory closed 2 months ago

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlory Once this PR has been reviewed and has the lgtm label, please assign priyankasaggu11929 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[config/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
carlory commented 2 months ago

/cc @aojea @pohly

aojea commented 2 months ago

we can keep the canary running more tests, it is optional and can be used to get signal on PRs ... the problem is the other way around, if the normal job runs more tests than the canary 😄

carlory commented 2 months ago

Thanks for review @aojea

If so, is it ready to merge https://github.com/kubernetes/test-infra/pull/32867? @pohly

/close

k8s-ci-robot commented 2 months ago

@carlory: Closed this PR.

In response to [this](https://github.com/kubernetes/test-infra/pull/32907#issuecomment-2209868379): >Thanks for review @aojea > >If so, is it ready to merge https://github.com/kubernetes/test-infra/pull/32867? @pohly > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.