search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.82k stars 2.63k forks source link

Kops - Migrate remaining presubmit jobs to k8s-infra-kops-prow-build #32919

Closed rifelpet closed 2 months ago

rifelpet commented 2 months ago

This canary job running on k8s-infra-kops-prow-build passed: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kops/16648/pull-kops-e2e-k8s-aws-calico-k8s-infra/1809653969442574336

So we should be good to migrate all remaining AWS presubmit jobs. We may need to open some kops cherrypicks if any of the release branch presubmits are missing certain kubetest2-kops changes, but we can confirm that after this merges.

/hold for confirmation from @upodroid that we're good to proceed

upodroid commented 2 months ago

Can you delete the temporary job you created?

rifelpet commented 2 months ago

Done ✅

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/jobs/kubernetes/kops/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/kops/OWNERS)~~ [rifelpet,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 2 months ago

@rifelpet: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

In response to [this](https://github.com/kubernetes/test-infra/pull/32919): >This canary job running on k8s-infra-kops-prow-build passed: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kops/16648/pull-kops-e2e-k8s-aws-calico-k8s-infra/1809653969442574336 > >So we should be good to migrate all remaining AWS presubmit jobs. We may need to open some kops cherrypicks if any of the release branch presubmits are missing certain kubetest2-kops changes, but we can confirm that after this merges. > >/hold for confirmation from @upodroid that we're good to proceed > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.