search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.83k stars 2.64k forks source link

k8s-infra-prow-build-trusted jobs should require requests/limits be set #32947

Open BenTheElder opened 3 months ago

BenTheElder commented 3 months ago

We're clearly not enforcing this currently, unlike the other k8s-infra clusters.

It will be a pain to do retroactively, but we really should be doing this, so we can effectively autoscale the cluster.

/sig k8s-infra testing

marcelgaedke commented 2 months ago

Hi @BenTheElder , I am new here and have been looking at this repo for a while and would like to start contributing. This isn't labeled as good first issue, but it seems doable. I would start by parsing all files under "config/jobs" to find all jobs running on "k8s-infra-prow-build-trusted" which are missing requests/limits. I may need some advice on how to determine proper values for requests/limits for each job. And I think the actual validation/enforcement for new jobs happens around "config/tests/jobs" ? If it's okay I would like to start working on this.

BenTheElder commented 2 months ago

I may need some advice on how to determine proper values for requests/limits for each job.

This is the problem indeed, we already have code to enforce this, but we can't turn it on for this cluster without figuring out that part, and access to where these jobs run is highly sensitive (it runs secure workloads for automating the project), I don't think we have a good way to grant access to just see the usage for these currently.

BenTheElder commented 2 months ago

This is why I didn't label it, because I don't know how to make that part accessible, and the folks with access are pretty focused on other work at the moment 😅

(in particular: https://groups.google.com/a/kubernetes.io/g/dev/c/p6PAML90ZOU)

BenTheElder commented 2 months ago

We also don't have agreement from any other leads yet, this issue hasn't been discussed yet. Normally we'd require agreement before requesting help. I appreciate the offer to help, but this probably isn't the best issue.

marcelgaedke commented 2 months ago

Alright. 👍 Thanks for taking the time to explain. I'll keep my eyes open for good first issues.