search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.83k stars 2.65k forks source link

Update gengo config #33420

Closed thockin closed 3 weeks ago

thockin commented 1 month ago

No need to bounce thru bash?

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/jobs/kubernetes/gengo/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/gengo/OWNERS)~~ [krzyzacy,thockin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 3 weeks ago

@thockin: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

In response to [this](https://github.com/kubernetes/test-infra/pull/33420): >No need to bounce thru bash? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
BenTheElder commented 3 weeks ago

No need to bounce thru bash?

There isn't now, because the wrapper script is running make as a subprocess of a shell already, but in the past we've relied on bash's PID reaping to avoid letting the test code leak pids.

Though, at least int he past, you had to make sure your "bash script" was just non-trivial enough to avoid bash simply exec-ing your command anyhow (replacing the bash process).

This probably happened through an attempt to mimic jobs that were forcing running under a shell.