search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.82k stars 2.63k forks source link

Eliminate .env files #3362

Closed spiffxp closed 5 years ago

fejta commented 6 years ago

We should just eliminate .env files

fejta commented 6 years ago

/close

spiffxp commented 6 years ago

reopening to clarify: is this done? or have we eliminated .env files?

krzyzacy commented 6 years ago

retitled for clarity

fejta-bot commented 6 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta. /lifecycle stale

spiffxp commented 6 years ago

/remove-lifecycle stale pretty sure we're still working on this, yeah? @krzyzacy @fejta

fejta-bot commented 6 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

krzyzacy commented 6 years ago

/remove-lifecycle stale /lifecycle frozen

BenTheElder commented 6 years ago

job definitions should be in prow/config.yaml, we can introspect this part of past jobs and modify it much more conveniently. ideally in the future our test images should not check out test-infra...

something to do along with killing off config.json #4794

spiffxp commented 6 years ago

We've still got a bunch

./jobs/env/ci-cri-containerd-e2e-gce.env
./jobs/env/ci-federation-e2e-gce-serial.env
./jobs/env/ci-federation-e2e-gce.env
./jobs/env/ci-kubernetes-e2e-gce-alpha-api.env
./jobs/env/ci-kubernetes-e2e-gce-device-plugin-gpu.env
./jobs/env/ci-kubernetes-e2e-gce-federation-release-1-8.env
./jobs/env/ci-kubernetes-e2e-gce-gci-latest-rollback-etcd.env
./jobs/env/ci-kubernetes-e2e-gce-gci-latest-upgrade-etcd.env
./jobs/env/ci-kubernetes-e2e-gce-gpu.env
./jobs/env/ci-kubernetes-e2e-gce-influxdb.env
./jobs/env/ci-kubernetes-e2e-gce-min-node-permissions.env
./jobs/env/ci-kubernetes-e2e-gce-multizone.env
./jobs/env/ci-kubernetes-e2e-gce-new-master-upgrade-cluster-new.env
./jobs/env/ci-kubernetes-e2e-gce-new-master-upgrade-cluster.env
./jobs/env/ci-kubernetes-e2e-gce-new-master-upgrade-master.env
./jobs/env/ci-kubernetes-e2e-gce-prometheus.env
./jobs/env/ci-kubernetes-e2e-gce-stackdriver.env
./jobs/env/ci-kubernetes-e2e-gce-taint-evict.env
./jobs/env/ci-kubernetes-e2e-gci-gce-alpha-features.env
./jobs/env/ci-kubernetes-e2e-gci-gce-autoscaling-migs.env
./jobs/env/ci-kubernetes-e2e-gci-gce-autoscaling.env
./jobs/env/ci-kubernetes-e2e-gci-gce-es-logging.env
./jobs/env/ci-kubernetes-e2e-gci-gce-ingress.env
./jobs/env/ci-kubernetes-e2e-gci-gce-ip-alias.env
./jobs/env/ci-kubernetes-e2e-gci-gce-netd.env
./jobs/env/ci-kubernetes-e2e-gci-gce-scalability-stable.env
./jobs/env/ci-kubernetes-e2e-gci-gce-scalability.env
./jobs/env/ci-kubernetes-e2e-gci-gce-sd-logging-k8s-resources.env
./jobs/env/ci-kubernetes-e2e-gci-gce-sd-logging.env
./jobs/env/ci-kubernetes-e2e-gci-gce-sig-cli.env
./jobs/env/ci-kubernetes-e2e-gci-gce.env
./jobs/env/ci-kubernetes-e2e-kops-aws.env
./jobs/env/ci-kubernetes-e2e-kubemark-common.env
./jobs/env/ci-kubernetes-e2e-scalability-common.env
./jobs/env/ci-kubernetes-e2e-scalability-highspeed-common.env
./jobs/env/ci-kubernetes-kubemark-gce-big.env
./jobs/env/ci-kubernetes-kubemark-gce-scale.env
./jobs/env/ci-kubernetes-kubemark-high-density-100-gce.env
./jobs/env/pull-federation-e2e-gce.env
./jobs/env/pull-kubernetes-e2e-containerd-gce.env
./jobs/env/pull-kubernetes-e2e-gce-device-plugin-gpu.env
./jobs/env/pull-kubernetes-e2e-gce.env
./jobs/env/pull-kubernetes-e2e-kops-aws.env
./jobs/env/pull-kubernetes-e2e.env
./jobs/platform/kops_aws.env
spiffxp commented 5 years ago

/milestone v1.13 I don't know if we'll get rid of all of them but I hope to take a crack at any jobs that are using etcd-related env vars this release cycle

krzyzacy commented 5 years ago

ok will take a final stab here

plan to make scalability env, or other heavily shared env a preset, and inline all other env files.