search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.85k stars 2.66k forks source link

pull-kubernetes-scheduler-perf: fix and enhance JUnit upload #33809

Closed pohly closed 1 week ago

pohly commented 1 week ago

The manual ARTIFACTS was wrong. It gets set to something else in the final pod YAML, so we must not override it.

With KUBE_PRUNE_JUNIT_TESTS=false (from https://github.com/kubernetes/kubernetes/pull/128834) we will get more detailed reporting.

pohly commented 1 week ago

/assign @macsko @sanposhiho

Should config/jobs/kubernetes/sig-scheduling/OWNERS get updated to reflect recent changes in the SIG?

dims commented 1 week ago

/approve /lgtm

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/jobs/kubernetes/sig-scheduling/OWNERS](https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-scheduling/OWNERS)~~ [dims] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 week ago

@pohly: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

In response to [this](https://github.com/kubernetes/test-infra/pull/33809): >The manual ARTIFACTS was wrong. It gets set to something else in the final pod YAML, so we must not override it. > >With KUBE_PRUNE_JUNIT_TESTS=false (from >https://github.com/kubernetes/kubernetes/pull/128834) we will get more detailed reporting. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
alculquicondor commented 1 week ago

Could this be related to the alert firing up for https://testgrid.k8s.io/sig-scheduling#scheduler-perf ?

pohly commented 1 week ago

I've been running pull-kubernetes-scheduler-perf a few times today, that must have triggered the alert. The latest run with this PR included is looking good so far (still running): https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/128834/pull-kubernetes-scheduler-perf/1858554004104024064

sanposhiho commented 1 week ago

Should config/jobs/kubernetes/sig-scheduling/OWNERS get updated to reflect recent changes in the SIG?

Created: https://github.com/kubernetes/test-infra/pull/33814