plugin to block "fixes #123" in commit messages

[BenTheElder]

this causes issues to repeatedly close when people merge into their forks, we should build a plugin to add a do-not-merge/* label to PRs that contain these types of strings in their commit messages

per discussion with @liggitt

/sig contributor-experience /sig testing /area prow /kind feature cc @cjwagner @stevekuznetsov

This is similar to the merge commits blocker https://github.com/kubernetes/test-infra/issues/5376

[guineveresaenger]

Can we explicitly list which types of strings?

[liggitt]

from https://help.github.com/articles/closing-issues-using-keywords/

one of those keywords followed by [\s:]+(\w+/\w+)?#\d+

also, not sure if you want to track it with this or separately, but preventing nick mentions in commit descriptions would be a boon to anyone who gets a hundred emails when a commit mentioning them gets pulled into all the various forks of a repo

[nikhita]

preventing nick mentions in commit descriptions would be a boon to anyone who gets a hundred emails when a commit mentioning them gets pulled into all the various forks of a repo

+100. Let’s please make this happen!

[nikhita]

@BenTheElder Re nick mentions: would this also mean that we would need to forbid @ mentions in the main PR body?

I think tide does not add the whole PR body in the merge commit message so this should not be needed but I'm not sure.

[BenTheElder]

We do not add the PR body anymore IIRC @cjwagner to confirm.

[spiffxp]

We do not

spiffxp@spiffxp-macbookpro:kubernetes (master %)$ git log --merges
commit 45c5ddd2fb8f10e097483257663fa6a7be59ffa9
Merge: 7bfd0d358c 55199a04be
Author: k8s-ci-robot <k8s-ci-robot@users.noreply.github.com>
Date:   Tue Sep 11 13:27:50 2018 -0700

    Merge pull request #68494 from k82cn/k8s_67606_2

    Added default tolerations for new pods.

[stevekuznetsov]

Both suggestions SGTM /help

[nikhita]

I'll take a dab at this.

[nikhita]

Created a PR: https://github.com/kubernetes/test-infra/pull/9387

/remove-help

[spiffxp]

/assign @nikhita

[jberkus]

Hey, looks like @nikhita is tackling the "invalid commit message", but NOT the "remove 'fixes'" issue.

Does anyone want to take on removing "fixes" statements? I'm having to reopen failing test issues all over the place now ...

[cjwagner]

I'm having to reopen failing test issues all over the place now ...

@jberkus Is that from "fixes" statements in commit messages or just in the PR body text?

[nikhita]

looks like @nikhita is tackling the "invalid commit message", but NOT the "remove 'fixes'" issue.

The PR also tackles the "fixes" issue in commit messages. But I probably won't have time to complete the PR this week. :(

[fejta-bot]

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

[fejta-bot]

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

[nikhita]

/remove-lifecycle rotten /lifeycle active