search

kubernetes / test-infra

Test infrastructure for the Kubernetes project.
Apache License 2.0
3.83k stars 2.65k forks source link

Replace tot with snowflake IDs #9604

Closed krzyzacy closed 5 years ago

krzyzacy commented 6 years ago

ref https://github.com/kubernetes/test-infra/issues/9593#issuecomment-425325474

/area prow cc @BenTheElder @cjwagner @spiffxp

spiffxp commented 6 years ago

/area gubernator Might have some impact here?

/area kettle We would definitely want to revisit kettle's impl

/area testgrid I don't know if this would impact testgrid at all, maybe during transition?

BenTheElder commented 6 years ago

testgrid should be unimpacted unless we decide to go back, going back would be problematic. gubernator otoh reads latest-build.txt and would be fine.

ixdy commented 6 years ago

/assign @fejta @BenTheElder cc @Katharine to fix gubernator cc @michelle192837 to fix testgrid and kettle

BenTheElder commented 6 years ago

I think testgrid already works fine? not sure about kettle cc @spiffxp Gubernator will need fixing or we'll need spyglass to be ready though

michelle192837 commented 6 years ago

TestGrid's fine in its current implementation as long as the IDs monotonically increase. It'll need tweaks if not.

BenTheElder commented 6 years ago

they're monotonic, just with gaps. testgrid is already handling some timestamp IDs so we should be good 👍 http://testgrid.k8s.io/conformance-cloud-provider-openstack#periodic-master

Katharine commented 6 years ago

Made the required gubernator change in #9911. It's slow.

Gubernator already has fallback logic in case latest-build.txt doesn't exist, so it might instead be preferable to just ensure there is no latest-build.txt?

Katharine commented 6 years ago

Gubernator changes are live, so that blocker is gone.

BenTheElder commented 6 years ago

so probably just check kettle and then we can look at deleting the service

Katharine commented 5 years ago

Looked into this briefly, we also need to set sequential: false as appropriate in kettle/buckets.yaml before we kill tot.

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

Katharine commented 5 years ago

/remove-lifecycle stale

There are no known (to me) blockers on this. We just need to pick a time we don't expect to matter an awful lot if things are on fire. After we work through the merge backlog at the beginning of the 1.15 cycle maybe?

We'll also have to loop in contribex and maybe kubernetes-dev because the numbers will be large and ugly and that's a change.

spiffxp commented 5 years ago

I'm in favor of trying this out, and yes we should give kubernetes-dev@ a heads up. My only ask is that we wait until v1.14 goes out the door.

Katharine commented 5 years ago

After 1.14 ships is my plan.

stevekuznetsov commented 5 years ago

/woof

k8s-ci-robot commented 5 years ago

@stevekuznetsov: dog image

In response to [this](https://github.com/kubernetes/test-infra/issues/9604#issuecomment-475752483): >/woof Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
spiffxp commented 5 years ago

/pony snowflake

k8s-ci-robot commented 5 years ago

@spiffxp: pony image

In response to [this](https://github.com/kubernetes/test-infra/issues/9604#issuecomment-475826170): >/pony snowflake Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Katharine commented 5 years ago

We did it!

/pony cheering /close

k8s-ci-robot commented 5 years ago

@Katharine: Closing this issue.

In response to [this](https://github.com/kubernetes/test-infra/issues/9604#issuecomment-476831816): >We did it! > >/pony cheering >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 5 years ago

@Katharine: pony image

In response to [this](https://github.com/kubernetes/test-infra/issues/9604#issuecomment-476831816): >We did it! > >/pony cheering >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
krzysied commented 5 years ago

Hi folks! Currently we are having issue with perfdash - it doesn't work. https://github.com/kubernetes/perf-tests/issues/469 Assuming that you made changes to the other tools, can someone give hints on how to work with the new run id format? We are using k8s.io/contrib/test-utils/utils/utils.go for accessing the run logs.