search

kubernetes / utils

Non-Kubernetes-specific utility libraries which are consumed by multiple projects.
Apache License 2.0
331 stars 196 forks source link

add github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 to shlex #300

Closed pacoxu closed 8 months ago

pacoxu commented 8 months ago

What type of PR is this? https://github.com/google/shlex is archived, so we may maintain it here.

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes: xref https://github.com/kubernetes-sigs/kustomize/issues/4963 and https://github.com/kubernetes/kubernetes/pull/114912

Special notes for your reviewer:

Since https://github.com/google/shlex is archived, we added it to unwanted dep list. However, before we have requirements to change it, we may keep it as is.

This may be a fix later if we have new requirement on shlex.

Release note:

Add google/shlex that is archived
k8s-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pacoxu Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/utils/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pacoxu commented 8 months ago

/close Since https://github.com/google/shlex is archived, we added it to unwanted dep list. However, before we have requirements to change it, we may keep it as is.

This may be a fix later if we have new requirement on shlex.

k8s-ci-robot commented 8 months ago

@pacoxu: Closed this PR.

In response to [this](https://github.com/kubernetes/utils/pull/300#issuecomment-1914292053): >/close >Since https://github.com/google/shlex is archived, we added it to unwanted dep list. >However, before we have requirements to change it, we may keep it as is. > >This may be a fix later if we have new requirement on shlex. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.