search

kubernetes / utils

Non-Kubernetes-specific utility libraries which are consumed by multiple projects.
Apache License 2.0
331 stars 196 forks source link

add test coverage to set.go #302

Closed logicalhan closed 5 months ago

logicalhan commented 7 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Missing coverage for a few of the set methods. This PR introduces additional coverage.

Release note:

NONE
skitt commented 5 months ago

/lgtm

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logicalhan, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[set/OWNERS](https://github.com/kubernetes/utils/blob/master/set/OWNERS)~~ [logicalhan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment