search

kubernetes / utils

Non-Kubernetes-specific utility libraries which are consumed by multiple projects.
Apache License 2.0
331 stars 196 forks source link

Add multi-listener test for HTTP #314

Closed thockin closed 2 months ago

thockin commented 2 months ago

I forgot to followup on this question, so I just did it myself. :)

/kind test

Release note:

NONE
k8s-ci-robot commented 2 months ago

@thockin: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes/utils/pull/314): >I forgot to followup on this question, so I just solved it myself. :) > >/kind test > >**Release note**: >``` >NONE >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
aroradaman commented 2 months ago

/lgtm

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aroradaman, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/utils/blob/master/OWNERS)~~ [thockin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment