search

kubernetes / utils

Non-Kubernetes-specific utility libraries which are consumed by multiple projects.
Apache License 2.0
331 stars 196 forks source link

Revert "Deprecate strings/slices functions covered by stdlib slices" #317

Closed gibizer closed 1 month ago

gibizer commented 1 month ago

This reverts commit 4965b0f13691de9f60deba4e3e0b4526f27aa76e as it incorrectly started using stdlib slices without declaring that this repo is now only compatible with golang >=1.21.

Closes: #316

linux-foundation-easycla[bot] commented 1 month ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 month ago

Welcome @gibizer!

It looks like this is your first PR to kubernetes/utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

gibizer commented 1 month ago

/easycla

gibizer commented 1 month ago

/easycla

gibizer commented 1 month ago

@thockin could you check this please? (Sorry for pinging directly but you were the approver of the commit I propose to revert here)

thockin commented 1 month ago

Oof. OK. We could add those "deprecated" comments sooner and change the impl later.

/lgtm /approve

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/utils/blob/master/OWNERS)~~ [thockin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment