kubernetes / website

Kubernetes website and documentation repo:
https://kubernetes.io
Creative Commons Attribution 4.0 International
4.56k stars 14.48k forks source link

Issue with k8s.io/docs/tutorials/stateful-application/zookeeper/ #16618

Open singhania opened 5 years ago

singhania commented 5 years ago

This is a Bug Report

Problem: Solution on zookeeper on kubernetes page does not have the latest version of zookeeper. Proposed Solution: It will be helpful if this zookeeper deployment can use new docker with latest zookeeper version.

Page to Update: https://kubernetes.io/docs/tutorials/stateful-application/zookeeper/

Latest

sftim commented 5 years ago

/kind cleanup /priority backlog

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 4 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 4 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes/website/issues/16618#issuecomment-592028748): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
r-joyce commented 3 years ago

Is there any plans to still do this? The image used in the article is about 3 years old now. It's honestly a well written example in my opinion, but sucks that once it's completed to realize how old of a version it is. Also doesn't look like there's a newer image in that repository from what I can tell.

There is a more up to date version on Docker Hub which can be found here, but that is also a completely different image and requires a complete rewrite. Ideally a newer image should just be pushed, but I don't know who's in charge of that.


Edit: Link to the container registry

sftim commented 3 years ago

/reopen

We should still do this. /remove-lifecycle rotten

sftim commented 3 years ago

/triage accepted

k8s-ci-robot commented 3 years ago

@sftim: Reopened this issue.

In response to [this](https://github.com/kubernetes/website/issues/16618#issuecomment-807852045): >/reopen > >We should still do this. >/remove-lifecycle rotten Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

aravindputrevu commented 3 years ago

I was routed to here from #28837 by @sftim , I wrote a tutorial on a stateful app Elasticsearch.

It'd be great to have some stateful app tutorials on the k8s.io website as it is visited by many devs. Moreover, these are general-purpose datastores that could help many to get started with.

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

sftim commented 3 years ago

/remove-lifecycle rotten

sftim commented 3 years ago

/lifecycle frozen

k8s-triage-robot commented 1 year ago

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

tengqm commented 1 year ago

/triage accepted

tengqm commented 1 year ago

Looks like this image was built 6 years ago and never updated.

tengqm commented 1 year ago

Check: https://github.com/kow3ns/kubernetes-zookeeper/blob/master/docker/Dockerfile

Gauravpadam commented 1 year ago

Looks like this issue is still relevant, Can I work on it?

tengqm commented 1 year ago

@Gauravpadam Sure you can work on it. Anyone can volunteer to contribute. Please bear in mind that we will need a working example, end to end. 3.4.10 is not too old a release for zookeeper. There is 3.9.0 on dockerhub, for example, but it doesn't mean everybody should use the latest version. When fixing this issue, please get your hands dirty by setting up this cluster environment. There may be some tricks along the way. I heard that someone spent 2 weeks to get this up and running. Be well prepared, ;).

Gauravpadam commented 1 year ago

Thanks for the heads up @tengqm! I'd like to try and help with this issue, Will start working on it

bianjp commented 4 months ago

Thanks for the heads up @tengqm! I'd like to try and help with this issue, Will start working on it

What approach would you take? Upgrading https://github.com/kow3ns/kubernetes-zookeeper/ or rewrite the tutorial to use https://hub.docker.com/_/zookeeper? It seems that kow3ns never responds to any issue or pull request.

sftim commented 1 month ago

/remove-lifecycle frozen

IMO: fixes are welcome, but if this rots and gets closed, that's a sign that it wasn't important to people.

bianjp commented 1 month ago

I have made a pull request to the official zookeeper image to add custom init scripts support (https://github.com/31z4/zookeeper-docker/pull/167). This will allow easier setup of myid for ZooKeeper cluster.

After that PR is accepted, I'd like to make a pull request to rewrite the tutorial to use latest official zookeeper image.