kubernetes / website

Kubernetes website and documentation repo:
https://kubernetes.io
Creative Commons Attribution 4.0 International
4.47k stars 14.39k forks source link

Code blocks not rendered properly in API Documentation (Quantity) #35712

Open Jefftree opened 2 years ago

Jefftree commented 2 years ago

This is a Bug Report

Problem: Code blocks not rendered properly in documentation

See https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.24/#quantity-resource-core

The Quantity description has a code block embedded in the code https://github.com/kubernetes/kubernetes/blob/3ffdfbe286ebcea5d75617da6accaf67f815e0cf/api/openapi-spec/v3/apis__node.k8s.io__v1_openapi.json#L177

(This is the same as what is provided in the swagger.json. The swagger.json file wasn't able to be linked because it's too large for Github's code search)

This is not being rendered properly and is just dumped on one line in the documentation

Proposed Solution: I haven't really looked into the code, is this something that can be fixed in the Markdown rendering?

Page to Update: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.24/#quantity-resource-core

^ Docs for future k8s versions

sftim commented 2 years ago

/remove-kind bug

/kind feature

We see reference doc generation as best-effort. There's definitely room for improvement.

RA489 commented 2 years ago

/triage accepted

sftim commented 2 years ago

Duplicated by https://github.com/kubernetes/website/issues/36947

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

Jefftree commented 1 year ago

/remove-lifecycle rotten

k8s-triage-robot commented 9 months ago

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

sftim commented 5 months ago

/remove-lifecycle rotten

sftim commented 5 months ago

Also affected: https://kubernetes.io/docs/reference/kubernetes-api/common-definitions/quantity/#Quantity

sftim commented 5 months ago

How I'd like this fixed:

We should either:

Optionally, also:

sftim commented 5 months ago

Also see https://github.com/kubernetes-sigs/reference-docs/issues/293

sftim commented 5 months ago

/triage accepted

sftim commented 4 months ago

/remove-kind feature /kind bug

sftim commented 3 months ago

Duplicated by https://github.com/kubernetes/website/issues/47070

robert-cronin commented 3 months ago

I have a couple of ideas for a potential fix for this issue if no one has picked it up yet. /assign

sftim commented 13 hours ago

Help is (still) welcome. It may be that most of the work is around getting the OpenAPI to contain the right Markdown, and then the docs generation becomes relatively easy.