kubernetes / website

Kubernetes website and documentation repo:
https://kubernetes.io
Creative Commons Attribution 4.0 International
4.45k stars 14.35k forks source link

Guaranteed Scheduling For Critical Add-On Pods task does not link to details of built in PriorityClasses #39000

Open aceeric opened 1 year ago

aceeric commented 1 year ago

Folks - on this page, regarding this language: "To mark a Pod as critical, set priorityClassName for that Pod to system-cluster-critical or system-node-critical. system-node-critical is the highest available priority, even higher than system-cluster-critical." This immediately brings to mind the question: "what do you mean by even higher, i.e. what is the effect?" A little searching yields this documentation which answers the question nicely. Consider adding some clarification on the effect of node vs cluster priority in your docs.

sftim commented 1 year ago

/retitle Guaranteed Scheduling For Critical Add-On Pods task does not link to details of built in PriorityClasses

We could and should update https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#priorityclass to incorporate details about the built-in priority classes.

It is OK to copy text verbatim from https://kubernetes.io/blog/2023/01/12/protect-mission-critical-pods-priorityclass/ and you can also use your own wording.

/language en /help /triage accepted /priority backlog

k8s-ci-robot commented 1 year ago

@sftim: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes/website/issues/39000): >/retitle Guaranteed Scheduling For Critical Add-On Pods task does not link to details of built in PriorityClasses > >We could and should update https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#priorityclass to incorporate details about the built-in priority classes. > >It is OK to copy text verbatim from https://kubernetes.io/blog/2023/01/12/protect-mission-critical-pods-priorityclass/ and you can also use your own wording. > >/language en >/help >/triage accepted >/priority backlog Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sftim commented 1 year ago

We should also update https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/ to link to https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#priorityclass once we update it.

rajeshdeshpande02 commented 1 year ago

I am working on this issue. /assign

vaibhav2107 commented 10 months ago

@rajeshdeshpande02 Are you still working on this issue

vaibhav2107 commented 3 months ago

Unassigning @rajeshdeshpande02 as didn't receive any updates. Please assign if you get back to this or anyone can also assign to this issue /unassign @rajeshdeshpande02

vaibhav2107 commented 3 months ago

/assign I would like to work on this issue