kubernetes / website

Kubernetes website and documentation repo:
https://kubernetes.io
Creative Commons Attribution 4.0 International
4.5k stars 14.43k forks source link

Umbrella issue: provide a clean up explanation for every code example #39683

Open 1dropaflame opened 1 year ago

1dropaflame commented 1 year ago

This is a Bug Report

Problem:

Code examples assume user knows how to clean up the environment after the example is done. However it is not as simple as deleting a file. One may have to reverse encryption, configs, delete deployments, services and pods.

Proposed Solution:

Every code example should have a section to clean up after itself. "Clean up".

Page to Update:

documentation pages on k8s.io

k8s-ci-robot commented 1 year ago

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mengjiao-liu commented 1 year ago

/remove-kind bug /kind feature

Ritikaa96 commented 1 year ago

Great catch @1dropaflame , This can be an umbrella issue with all the pages mentioned. I'd be glad to contribute some of it.

sftim commented 1 year ago

/remove-kind bug /kind feature /retitle Umbrella issue: provide a clean up explanation for every code example

Thorough implementation will be tricky. Some things can't be definitively undone, such as a node reboot. It doesn't mean we can't try.

We might want to split this further, into explaining cleanup for tutorial pages (which I see as vital and as something that readers can reasonably expect) and for task pages (which I think is much more dependent on the specific task being explained). I'm wary of making a 400 word task page turn into a 10000 word task page that fully explains how to back up first, then test the backup, then do the task, etc.

k8s-ci-robot commented 1 year ago

@sftim: Those labels are not set on the issue: kind/bug

In response to [this](https://github.com/kubernetes/website/issues/39683#issuecomment-1445973179): >/remove-kind bug >/kind feature >/retitle Umbrella issue: provide a clean up explanation for every code example > >Thorough implementation will be tricky. Some things **can't** be definitively undone, such as a node reboot. It doesn't mean we can't try. > >We might want to split this further, into explaining cleanup for tutorial pages (which I see as vital and as something that readers can reasonably expect) and for task pages (which I think is much more dependent on the specific task being explained). I'm wary of making a 400 word task page turn into a 10000 word task page that fully explains how to back up first, then test the backup, then do the task, etc. > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Ritikaa96 commented 1 year ago

@sftim In the tutorials section, some tutorials like Learn Kubernetes Basics have interactive tutorials. Adding cleanup to them doesn't seem feasible. we can list out other pages to add cleanup here as task. what do you say?

sftim commented 1 year ago

We don't know what we'll do with interactive tutorials. Let's assume people will in future be following along at home - see https://kubernetes.io/blog/2023/02/14/kubernetes-katacoda-tutorials-stop-from-2023-03-31/

Ritikaa96 commented 1 year ago

Do we need more info to accept this issue and tag triage-accepted? I guess people might start working on the cleanup info only once it is accepted.

KhushPatibandha commented 1 year ago

Think I can resolve this issue, I'll look into this.

KhushPatibandha commented 1 year ago

/assign

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Ritikaa96 commented 1 year ago

/remove-lifecycle stale

vaibhav2107 commented 11 months ago

@KhushPatibandha Are you still working on this issue?

k8s-triage-robot commented 8 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

divya-mohan0209 commented 6 months ago

To all new contributors looking at this issue - we have not put a triage/accepted label on this & do not recommend you take up this issue as your first issue. /remove-lifecycle rotten

divya-mohan0209 commented 6 months ago

@sftim : I do like the idea you have proposed & it'd be great to have it entered as the description. Although as maintainers, we can do it, @1dropaflame , please could you edit the description, if the suggestion by Tim looks good to you?

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

vaibhav2107 commented 3 months ago

/remove-lifecycle stale

k8s-triage-robot commented 1 hour ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale