kubernetes / website

Kubernetes website and documentation repo:
https://kubernetes.io
Creative Commons Attribution 4.0 International
4.46k stars 14.36k forks source link

Add way to dismiss banners in the K8s website #39887

Closed AntonioND closed 6 months ago

AntonioND commented 1 year ago

This is a Feature Request

The red banner introduced with https://github.com/kubernetes/website/pull/39575 is too intrusive. Most Kubernetes users don't actually care about this deadline, and there is no way to dismiss it.

What would you like to be added

A simple "dismiss" button that sets a cookie to hide the banner in any future visit, like other websites do.

Why is this needed

I'd argue that most users of the website just want to read the documentation, they aren't going to submit images to that registry, so the warning isn't useful.

Comments

This could be reused for future banners.

k8s-ci-robot commented 1 year ago

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sftim commented 1 year ago

/retitle Add way to dismiss banners in the K8s website

We would implement this for all banners, not just red ones.

sftim commented 1 year ago

/area web-development

dims commented 1 year ago

@AntonioND oh boy! are you in for a ride!!

dims commented 1 year ago

xref: https://github.com/kubernetes/k8s.io/issues/4872

also, here's how i deal with papercuts on the web - https://userstyles.org/help/stylish_chrome

XDRAGON2002 commented 1 year ago

/retitle Add way to dismiss banners in the K8s website

We would implement this for all banners, not just red ones.

Which all banners are you referring to? I'd be willing to take this up.

sftim commented 1 year ago

There's a banner displayed now, it looks like this: Banner screenshot

Imagine if you could click to acknowledge that you'd read it and didn't want to see it again for a fortnight.

(separately: https://github.com/kubernetes/website/issues/39887#issuecomment-1463676947 does feel relevant - @AntonioND ruled out taking action as they don't plan to push a container image there, which I think reveals a misunderstanding. I think it's worth repeating banners every couple of weeks in case it helps a message to land better).

BenTheElder commented 1 year ago

[...] which I think reveals a misunderstanding. [...]

Which ...To clarify for anyone reading: This banner applies to pulling / downloading container images from the Kubernetes project, this banner is aimed at users, not Kubernetes developers. Nobody can push directly to either of these hosts and the change isn't related to pushing / submitting images.

XDRAGON2002 commented 1 year ago

Thanks @sftim and @BenTheElder for the explanation! I'll take this up and try to resolve this.

/assign

KhushPatibandha commented 1 year ago

@XDRAGON2002 are you working on this issue? I would like to help if you want. Do let me know.

XDRAGON2002 commented 1 year ago

Yes, @KhushPatibandha I'm working on this still, mostly it's completed already, but thanks for the offer!

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

mtilson commented 9 months ago

@KhushPatibandha As XDRAGON2002 seems is evaded, could you please proceed?

Gauravpadam commented 9 months ago

/remove-lifecycle stale

Gauravpadam commented 9 months ago

I'll help with this, it seems like a good feature

aj11anuj commented 8 months ago

/sig docs