Improve clarity on synchronous and asynchronous nature of Container hooks handlers

pulkits15 commented 1 year ago

This paragraph is a bit confusing -

Hook handler calls are synchronous within the context of the Pod containing the Container. This means that for a PostStart hook, the Container ENTRYPOINT and hook fire asynchronously. However, if the hook takes too long to run or hangs, the Container cannot reach a running state.

In first line, call is said to be synchronous. In second line asynchronously

dipesh-rawat commented 1 year ago

Page related to issue: https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/ /language en

dipesh-rawat commented 1 year ago

/retitle Improve clarity on synchronous and asynchronous nature of Container hooks handlers

niranjandarshann commented 1 year ago

You can find the information and the entire paragraph on the Page: https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/#hook-handler-execution. /sig docs /kind support

sftim commented 1 year ago

BTW we'd welcome a rewording that has the same meaning but that is easier for people to understand.

The existing text is correct but clearly at least one contributor did not understand it first go.

sftim commented 8 months ago

/remove-kind support

I think there's something we can fix here.

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 4 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle rotten
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

divya-mohan0209 commented 4 months ago

/remove-lifecycle rotten

divya-mohan0209 commented 4 months ago

/triage accepted

divya-mohan0209 commented 4 months ago

For contributors picking up this issue, please note the following:

We'd like to improve the existing text per this comment by Tim. You may propose a PR with your suggested changes and do not need to ask us for permission.
The page to be amended is: https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/#hook-handler-execution

/help

k8s-ci-robot commented 4 months ago

@divya-mohan0209: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

Why are we solving this issue?
To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
Does this issue have zero to low barrier of entry?
How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes/website/issues/41219): >For contributors picking up this issue, please note the following: >- We'd like to improve the existing text per [this comment](https://github.com/kubernetes/website/issues/41219#issuecomment-1557124784) by Tim. You may propose a PR with your suggested changes and do not need to ask us for permission. >- The page to be amended is: https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/#hook-handler-execution > >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

network-charles commented 3 months ago

/assign

kubernetes / website

Improve clarity on synchronous and asynchronous nature of Container hooks handlers #41219

Guidelines