search

kubernetes / website

Kubernetes website and documentation repo:
https://kubernetes.io
Creative Commons Attribution 4.0 International
4.46k stars 14.38k forks source link

CRI Pod: unclear explanation about cAdvisor in the kubelet #43244

Closed nnlkcncff closed 1 year ago

nnlkcncff commented 1 year ago

https://kubernetes.io/docs/reference/instrumentation/cri-pod-container-metrics/ The kubelet collects pod and container metrics via cAdvisor.

The sentense is confusing because it lacks detail. Two problems: 1) One cannot understand where this metrics are. Acording to the PodAndContainerStatsFromCRI feature gate the location is in the kubelet API at /metrics/cadvisor. 2) There wasn't any information on Concepts and Reference chapters before, but according to Node metrics data subchapter it states that cAdvisor is embedded in the kubelet.

Also it would also be useful to add a link to cAdvisor metrics to clarify exactly what metrics are meant.

Please, consider adding this information to the page.

P.S. It’s also interesting where one can find a description of the metrics located in /metrics for kubelet, kube-proxy, kube-scheduler and kube-controller-manager, something like here or here.

k8s-ci-robot commented 1 year ago

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dipesh-rawat commented 1 year ago

Page related to issue: https://kubernetes.io/docs/reference/instrumentation/cri-pod-container-metrics/ /language en

dipesh-rawat commented 1 year ago

/sig node

tengqm commented 1 year ago

I'm wondering if we really need to add documentations for the cAdvisor metrics. They are to be replaced by a kube-native mechanism. The substitution is still on-going. I'm not confident that someone will come up with a reference for this. This issue is gonna die away eventually. Feel free to reopen it if there are some heroes to step up for this challenge. /close

k8s-ci-robot commented 1 year ago

@tengqm: Closing this issue.

In response to [this](https://github.com/kubernetes/website/issues/43244#issuecomment-1752563932): >I'm wondering if we really need to add documentations for the cAdvisor metrics. >They are to be replaced by a kube-native mechanism. >The substitution is still on-going. >I'm not confident that someone will come up with a reference for this. >This issue is gonna die away eventually. >Feel free to reopen it if there are some heroes to step up for this challenge. >/close > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.