search

kubernetes / website

Kubernetes website and documentation repo:
https://kubernetes.io
Creative Commons Attribution 4.0 International
4.5k stars 14.43k forks source link

ready pod status still listed as a beta feature, became GA in 1.29 #44632

Open hahewlet opened 10 months ago

hahewlet commented 10 months ago

This is a Bug Report

Problem: According to KEP https://github.com/kubernetes/enhancements/issues/2879, The JobReadyPods feature gate has moved to GA with K8s 1.29. I see this correctly reflected in the feature gate doc, https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/. However, the Job API doc, https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/job-v1/#JobStatus, lists the ready state as a beta feature. Text from the doc:

Beta level ready (int32)

The number of pods which have a Ready condition.

This field is beta-level. The job controller populates the field when the feature gate JobReadyPods is enabled (enabled by default).

Proposed Solution: Move the ready state information from the beta section to the main list under the JobStatus section.

Page to Update: https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/job-v1/#JobStatus

Kubernetes Version: 1.29

hahewlet commented 10 months ago

@alculquicondor for awareness.

alculquicondor commented 10 months ago

Uhm... this was already fixed https://github.com/kubernetes/kubernetes/pull/121765

Not sure if there was a missing sync into the website page.

hahewlet commented 10 months ago

I don't see the markdown page explicitly listed in the committed files under https://github.com/kubernetes/kubernetes/pull/121765. When I look in the main branch, https://github.com/kubernetes/website/blob/main/content/en/docs/reference/kubernetes-api/workload-resources/job-v1.md#beta-level-1 I see the beta reference. Perhaps this was missed?

sftim commented 10 months ago

/sig apps

If the API or command line tool reference is out of date, a contributor needs to regenerate it and then send in a pull request.

sftim commented 10 months ago

/language en /triage accepted

professorabhay commented 10 months ago

Hey, @sftim ! I would like to do it. Will raise a PR.

Anuragt1104 commented 10 months ago

/assign

professorabhay commented 10 months ago

/unassign @Anuragt1104

professorabhay commented 10 months ago

Hey @Anuragt1104, I'm already working on it and will raise the PR soon.

professorabhay commented 10 months ago

/assign

professorabhay commented 10 months ago

Hey, @hahewlet ! Kindly take a look at the PR.