kubernetes / website

Kubernetes website and documentation repo:
https://kubernetes.io
Creative Commons Attribution 4.0 International
4.5k stars 14.45k forks source link

𝕏 (formerly, Twitter) icon not showing in website footer #46405

Open ArvindParekh opened 6 months ago

ArvindParekh commented 6 months ago

This is a Feature Request

What would you like to be added

The k8s.io website footer doesn't have a link to its 𝕏 account (@kubernetesio), which is now maintained by the Kubernetes community alongside CNCF. I suggest we should add that.

image

Why is this needed

Comments

I guess I should add it to the left group. Let me know if there's any feedback.

ArvindParekh commented 6 months ago

/assign

dipesh-rawat commented 6 months ago

Thank you for reporting this issue! It appears that there is already 𝕏 detail in the footer (as seen the HTML source below), but the icon isn't rendering.

<li class="list-inline-item mx-2 h3" data-toggle="tooltip" data-placement="top" title="" 
aria-label="X(Twitter)" data-original-title="X(Twitter)">
       <a class="text-white" target="_blank" href="https://twitter.com/kubernetesio">
            <i class="fab fa-x-twitter"></i>
        </a>
</li>
dipesh-rawat commented 6 months ago

This looks like a bug. /remove-kind feature

/retitle 𝕏 (formerly, Twitter) icon not showing in website footer /kind bug /area web-development

dipesh-rawat commented 6 months ago

Previously, the old Twitter logo was rendering properly (refer to the v1.28 docs website (here)).

I think it's after our work involved to update to " 𝕏 " that the logo stopped rendering (refer to the commit https://github.com/kubernetes/website/commit/803bb6b16b6d678fd5b3ecef1debde6e81865081 where it was added). It could be that the version of Font Awesome being used by the current version of Docsy is outdated and doesn't include the new icon.

The footer 𝕏 icon details are pulled from hugo.toml (refer below). https://github.com/kubernetes/website/blob/44669d56d7329c0a12eeaac31318f3025a91e51e/hugo.toml#L252-L255

dipesh-rawat commented 6 months ago

We should fix this issue in the footer.

/priority backlog /triage accepted

tengqm commented 6 months ago

fontawsome 4.7.0 doesn't include this icon, the rename only happened a short time ago. Try search "x-twitter" on https://fontawesome.com/v4/icons/.

ArvindParekh commented 6 months ago

Oh got it! Thank you for explaining and providing the links @dipesh-rawat!

Try search "x-twitter" on https://fontawesome.com/v4/icons/.

I did, v4 does not include the X Twitter icon, even v5 doesn't have it, it was introduced in the latest version (v6) of fontAwesome.

It could be that the version of Font Awesome being used by the current version of Docsy is outdated and doesn't include the new icon.

I just checked the latest Docsy release, where they have bumped fontAwesome to the latest release version 6.5.2 (see #1925)

Which means, updating the icon name in hugo.toml (to fa-brands fa-x-twitter, which are the classnames for x-twitter in the latest release) should fix this issue, right?

Shubham82 commented 6 months ago

fontawsome 6.5.2 includes x-twitter icon, https://fontawesome.com/v6/search?q=twitter&o=r

chris-short commented 6 months ago

@sftim and I were discussing this very topic this week. I checked FontAwesome too and couldn't distinguish the differences.

ktvargo-ms commented 4 months ago

It could be that the version of Font Awesome being used by the current version of Docsy is outdated and doesn't include the new icon.

I just checked the latest Docsy release, where they have bumped fontAwesome to the latest release version 6.5.2 (see #1925)

Yes, it looks this uses an older version of Docsy and an upgrade to the latest/newer version of Docsy is required to get newer fontawesome fonts. Of course, that impacts the entire site.

chris-short commented 2 months ago

FontAwesome is a submodule of Docsy if I recall. That could be updated independently I would imagine. I do manually adds to my personal site's iconography routinely.

cc @jberkus