kubernetes / website

Kubernetes website and documentation repo:
https://kubernetes.io
Creative Commons Attribution 4.0 International
4.38k stars 14.14k forks source link

Improvement for k8s.io/docs/concepts/policy/limit-range/ #46899

Open vsagar100 opened 4 weeks ago

vsagar100 commented 4 weeks ago

LimitRange is namespace specific, however the given example does not contain namespace attribute. I know it will pick default namespace however mentioning it will be more clear & helpful for beginners like me.

thisisharrsh commented 4 weeks ago

/language en /sig docs

thisisharrsh commented 4 weeks ago

Mentioning the namespace in a LimitRange object can improve the clarity. Page related to the issue: https://kubernetes.io/docs/concepts/policy/limit-range/ /sig node

sftim commented 4 weeks ago

We can also add a comment into the manifest about the namespace being implied. Using a comment helps people test things out in namespaces other than default.

Shubhdeep02 commented 4 weeks ago

Hey @vsagar100 I think It's already mentioned clearly about the constraints and the steps of using it in LimitRange object, and you can also take help from the docs for more understanding: https://kubernetes.io/docs/tasks/administer-cluster/namespaces/

vsagar100 commented 4 weeks ago

Hey @vsagar100 I think It's already mentioned clearly about the constraints and the steps of using it in LimitRange object, and you can also take help from the docs for more understanding: https://kubernetes.io/docs/tasks/administer-cluster/namespaces/

@Shubhdeep02, I am talking about the below page. It might have been mentioned on the page you mentioned. I was following LimitRange page but found it missing hence requested update. Page Link: https://kubernetes.io/docs/concepts/policy/limit-range/

subhals commented 2 weeks ago

/assign

T-Lakshmi commented 1 week ago

/triage accepted

T-Lakshmi commented 1 week ago

PR working on this #46950