search

kubernetes / website

Kubernetes website and documentation repo:
https://kubernetes.io
Creative Commons Attribution 4.0 International
4.49k stars 14.43k forks source link

Adding entries to Pod /etc/hosts with HostAliases #47700

Closed GergelyMolnar closed 1 month ago

GergelyMolnar commented 2 months ago

Hi,

On this page: https://kubernetes.io/docs/tasks/network/customize-hosts-file-for-pods/ I found a sentence that is hard to understand because of the double negative.

The sentence is in the first paragraph: """ Modification not using HostAliases is not suggested because the file is managed by the kubelet and can be overwritten on during Pod creation/restart. """

It would be easier to read and understand by replacing the double negative: "Modification using the HostAliases field in the PodSpec is recommended because changes made in other ways may be overwritten by the kubelet during Pod creation or restart."

o7

k8s-ci-robot commented 2 months ago

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dipesh-rawat commented 2 months ago

Hi @GergelyMolnar Could you please provide the URL of the page in the issue where you are suggesting an improvement?

/triage needs-information

GergelyMolnar commented 2 months ago

Sure, the page is here: https://kubernetes.io/docs/tasks/network/customize-hosts-file-for-pods/

tamilselvan1102 commented 2 months ago

Good spotting it. it should be corrected. I would like to work on it if triage accepted.

tamilselvan1102 commented 2 months ago

/language en

ayushpatil2122 commented 1 month ago

/assign

niranjandarshann commented 1 month ago

I think the issue is resolved as the PR get merged. So closing this issue. /close

k8s-ci-robot commented 1 month ago

@niranjandarshann: Closing this issue.

In response to [this](https://github.com/kubernetes/website/issues/47700#issuecomment-2395308740): >I think the issue is resolved as the PR get merged. >So closing this issue. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.