kubernetes / website

Kubernetes website and documentation repo:
https://kubernetes.io
Creative Commons Attribution 4.0 International
4.44k stars 14.33k forks source link

Logo overlaps with other nav bar elements when search bar is present (on Firefox) #47889

Open holistic-developer opened 1 week ago

holistic-developer commented 1 week ago

This is a Bug Report

Problem: On Firefox the kubernetes logo overlaps with other navbar items on .../docs pages when the search bar is present. image

Proposed Solution: Decrease the size of the search bar.

Page to Update: All pages using the layouts/partials/navbar.html which is mostly https://kubernetes.io/docs/

Additional Information I used Firefox version 130 on Mac with a resolution of 1512 x 982

holistic-developer commented 1 week ago

This might be related to https://github.com/kubernetes/website/issues/45077

dipesh-rawat commented 1 week ago

/area web-development

thisisharrsh commented 1 week ago

/assign

thisisharrsh commented 1 week ago

Facing the same issue at 1512 * 982 resolution. Screenshot from 2024-09-12 10-24-15

sftim commented 1 week ago

My suggestion: drop the Case Studies section.

thisisharrsh commented 5 days ago

drop the Case Studies section.

I am planning to adjust the CSS properties for the page at the given size. But I will consider your suggestion also.

holistic-developer commented 5 days ago

My suggestion: drop the Case Studies section.

I would advise against that.

Here is how it is rendered in chrome at the same resolution:

image

and again on Firefox image So, the actual issue is the size of the search bar.

thisisharrsh commented 5 days ago

Thanks @holistic-developer, for the issue rectification.

sftim commented 5 days ago

@holistic-developer several changes could help:

katcosgrove commented 4 days ago

/triage accepted /priority important-soon

sftim commented 4 days ago

When I shrink the viewport to a similar width, the search form within the nav bar disappears completely. But maybe this is too dependent on details such as DPI, root element em size, etc.

thisisharrsh commented 4 days ago

The issue is fixed here.

thisisharrsh commented 4 days ago
  • Managing the size of the search bar

Raised the PR on this approach.