Kubernetes Feature Gate Information On Website Incorrect For ~6 Features

aaron-prindle commented 1 month ago

This is a Bug Report

Problem: In going through the a number of the kubernetes feature gates alpha, beta, and GA release dates in kubernetes/kubernetes pkg/features/kube_features.go as part of a PR review for https://github.com/kubernetes/kubernetes/pull/126791 - I found some inaccuracies on the kube feature gate information that is currently hosted on the kubernetes website (and thus in this repo). In my analysis I looked at the pkg/features/kube_features.go file of the specified kubernetes release (eg: vX.Y.Z branch) and compared the feature status in that file to what is stated in the files in kubernetes/website content/en/docs/reference/command-line-tools-reference/feature-gates. Below is my list of discrepancies that I discovered:

EDIT: Additionally more discrepencies were discovered in the thread here: https://github.com/kubernetes/kubernetes/pull/127200#discussion_r1768862429

Note: below kubernetes/website JSON is a custom struct and differs from the website syntax BUT the values/info is identical

Add missing GA entry for DisableCloudProviders { "name": "disable-cloud-providers", "started_alpha": "1.22", "alpha_default_value": false, "started_beta": "1.29", "beta_default_value": true // missing "started_GA": "1.31", "GA_default_value": true },
Update website to have DynamicResourceAllocation at alpha: v1.29 { "name": "dynamic-resource-allocation", "started_alpha": "1.30", // should be 1.29 "alpha_default_value": false },
Add missing alpha entry for NewVolumeManagerReconstruction { "name": "new-volume-manager-reconstruction", // missing "started_alpha": "1.25", "alpha_default_value": false, "started_beta": "1.27", "beta_default_value": false, // should be true "started_GA": "1.30", "GA_default_value": true },
Add missing beta entry for DisableCloudProviders { "name": "proc-mount-type", "started_alpha": "1.12", "alpha_default_value": false // missing "started_beta": "1.31", "beta_default_value": false },
Add missing alpha entry for TranslateStreamCloseWebsocketRequests { "name": "translate-stream-close-websocket-requests", // missing "started_alpha": "1.29", "alpha_default_value": false, "started_beta": "1.30", "beta_default_value": true },
Add missing beta entry for CSIMigrationPortworx { "name": "csi-migration-portworx", "started_alpha": "1.23", "alpha_default_value": false, "started_beta": "1.25", "beta_default_value": false // missing "started_beta": "1.31", "beta_default_value": true },

Proposed Solution: Update the associated content/en/docs/reference/command-line-tools-reference/feature-gates/\<feature> file for all of the features with discrepancies noted above.

Page to Update: content/en/docs/reference/command-line-tools-reference/feature-gates/\<feature>

k8s-ci-robot commented 1 month ago

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

mengjiao-liu commented 1 month ago

The reason for the inconsistency is that many updates have not yet been merged.

TBD if needed - Add AppArmorFields feature (missing on kubernetes/website)

TBD if needed - Add DisableAllocatorDualWrite feature (missing on kubernetes/website)

TBD if needed - Add ReloadKubeletServerCertificateFile feature (missing on kubernetes/website)

These have been submitted to: