kubernetes / website

Kubernetes website and documentation repo:
https://kubernetes.io
Creative Commons Attribution 4.0 International
4.5k stars 14.45k forks source link

[zh] Link to etcd docs starts with a forward slash #48140

Closed SayakMukhopadhyay closed 1 month ago

SayakMukhopadhyay commented 1 month ago

This is a Bug Report

Problem: In the Chinese docs, the link to the etcd FAQ starts with a forward slash https://github.com/kubernetes/website/blob/a76d35dabb42a349bd8ad727f0eb0fe54e388f34/content/zh-cn/docs/setup/production-environment/_index.md?plain=1#L233

This is causing Hugo to error out when building in Windows. Since this line has been there for quite a few years, I don't know how Hugo kept building till now. Anyway, this slash is creating the wrong link in production itself. image

Proposed Solution: Just removing the slash is enough. Page to Update: https://kubernetes.io/zh-cn/docs/setup/production-environment/

This issue is present in the docs for older versions too. Should we look into fixing it for other branches?

SayakMukhopadhyay commented 1 month ago

/assign @SayakMukhopadhyay

sftim commented 1 month ago

/triage accepted

SayakMukhopadhyay commented 1 month ago

This issue is present in the docs for older versions too. Should we look into fixing it for other branches?

@sftim Should I look into fixing this issue in older versions of the page?

tengqm commented 1 month ago

/assign

sftim commented 1 month ago

@SayakMukhopadhyay backport fixes are welcome, but we don't require them.

SayakMukhopadhyay commented 1 month ago

I guess, I will leave them be then😅