kubeadm-join: misleading paragraph

dejanu commented 3 days ago

First sentence from kubeadm-join it's a little bit misleading: "This command initializes a Kubernetes worker node and joins it to the cluster. Run this on any machine you wish to join an existing cluster" For newcomers it might be understand as it's applicable only for worker nodes.

neolit123 commented 3 days ago

this seems like a leftover from when kubeadm only supported worker nodes to join, not control plane nodes.

/help /good-first-issue /kind bug /sig cluster-lifeecycle

steps

leave a comment here /assign ... to assign your self
edit the page https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-join/
change the sentences:

from:

This command initializes a Kubernetes worker node and joins it to the cluster.
Run this on any machine you wish to join an existing cluster.

to:

This command can be used to join a new Kubernetes node to an existing cluster.

send a Pull Request for the change
make it close this issue with closes #48399 in the PR description
leave another comment here that you have a PR

k8s-ci-robot commented 3 days ago

@neolit123: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

Why are we solving this issue?
To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
Does this issue have zero to low barrier of entry?
How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubernetes/website/issues/48399): >this seems like a leftover from when kubeadm only supported worker nodes to join, not control plane nodes. > >/help >/good-first-issue >/kind bug >/sig cluster-lifeecycle > >steps >- leave a comment here `/assign ...` to assign your self >- edit the page https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-join/ >- change the sentences: > >from: >``` >This command initializes a Kubernetes worker node and joins it to the cluster. >Run this on any machine you wish to join an existing cluster. >``` > >to: >``` >This command can be used to join a new Kubernetes node to an existing cluster. >``` > >- send a Pull Request for the change >- make it close this issue with `closes #48399` in the PR description >- leave another comment here that you have a PR > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

k8s-ci-robot commented 3 days ago

@neolit123: The label(s) sig/cluster-lifeecycle cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes/website/issues/48399#issuecomment-2418771122): >this seems like a leftover from when kubeadm only supported worker nodes to join, not control plane nodes. > >/help >/good-first-issue >/kind bug >/sig cluster-lifeecycle > >steps >- leave a comment here `/assign ...` to assign your self >- edit the page https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-join/ >- change the sentences: > >from: >``` >This command initializes a Kubernetes worker node and joins it to the cluster. >Run this on any machine you wish to join an existing cluster. >``` > >to: >``` >This command can be used to join a new Kubernetes node to an existing cluster. >``` > >- send a Pull Request for the change >- make it close this issue with `closes #48399` in the PR description >- leave another comment here that you have a PR > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

neolit123 commented 3 days ago

/sig cluster-lifecycle

neolit123 commented 3 days ago

/retitle kubeadm-join: misleading paragraph /triage accepted

T-Lakshmi commented 3 days ago

leave another comment here that you have a PR

PR Raised for this issue #48400.

kubernetes / website

kubeadm-join: misleading paragraph #48399

Guidelines