kubernetes / website

Kubernetes website and documentation repo:
https://kubernetes.io
Creative Commons Attribution 4.0 International
4.51k stars 14.47k forks source link

Clarification for milestone-maintainer post Code-Freeze (2/2) #48833

Open gracenng opened 23 hours ago

gracenng commented 23 hours ago

Folks have been adding milestone to their PRs post Code-Freeze, which they shouldn't do. We're adding documentation to discourage that behaviour.

Also updated here: https://github.com/kubernetes/sig-release/pull/2668

cc @katcosgrove @fsmunoz

netlify[bot] commented 22 hours ago

Pull request preview available for checking

Built without sensitive environment variables

Name Link
Latest commit dc87111e2dac849b1ff373763c78267d4c673140
Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6743fb0dcea44700080ebff4
Deploy Preview https://deploy-preview-48833--kubernetes-io-main-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim commented 9 hours ago

https://github.com/kubernetes/sig-release/pull/2668 has merged

/hold cancel

/approve

k8s-ci-robot commented 9 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[content/en/releases/OWNERS](https://github.com/kubernetes/website/blob/main/content/en/releases/OWNERS)~~ [sftim] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
gracenng commented 9 hours ago

Thanks for the review folks! I didn't realize this was auto-generated, curious why manual edit is OK here?

sftim commented 9 hours ago

Oh! I'd thought you'd changed this to exactly align with the change to https://github.com/kubernetes/sig-release/pull/2668

If not, please do an auto-update and revise the PR accordingly.