kubesaw / ksctl

ksctl is a command-line tool to manage your installation of KubeSaw
Apache License 2.0
4 stars 11 forks source link

remove unused 'path' after loading config #13

Closed xcoulon closed 8 months ago

xcoulon commented 8 months ago

not used in the code

Signed-off-by: Xavier Coulon xcoulon@redhat.com

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 65.33%. Comparing base (650c3ec) to head (3741a10).

Files Patch % Lines
pkg/configuration/configuration.go 45.45% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #13 +/- ## ========================================== - Coverage 65.35% 65.33% -0.02% ========================================== Files 38 38 Lines 1980 1979 -1 ========================================== - Hits 1294 1293 -1 Misses 528 528 Partials 158 158 ``` | [Flag](https://app.codecov.io/gh/kubesaw/ksctl/pull/13/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubesaw) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/kubesaw/ksctl/pull/13/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubesaw) | `65.33% <45.45%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubesaw#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MatousJobanek commented 8 months ago

Good question @fbm3307, there are two cases we could theoretically cover, the rest of the complains are related to reading from your home directory (which is very hard to mock and test if you don't want to mess with your home directory), or to some filesystem errors when loading the content of the files, which is very hard to unit test as well.

Anyway, we can take a look at the two cases (when the provided kubeconfig doesn't exist, or when it's a directory) in separate PR - this one is just for dropping the field.