Closed xcoulon closed 8 months ago
Attention: Patch coverage is 45.45455%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 65.33%. Comparing base (
650c3ec
) to head (3741a10
).
Files | Patch % | Lines |
---|---|---|
pkg/configuration/configuration.go | 45.45% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Good question @fbm3307, there are two cases we could theoretically cover, the rest of the complains are related to reading from your home directory (which is very hard to mock and test if you don't want to mess with your home directory), or to some filesystem errors when loading the content of the files, which is very hard to unit test as well.
Anyway, we can take a look at the two cases (when the provided kubeconfig doesn't exist, or when it's a directory) in separate PR - this one is just for dropping the field.
not used in the code
Signed-off-by: Xavier Coulon xcoulon@redhat.com